| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Only affects the new build system, so merging now. A |
Sorry, something went wrong.
There was a problem hiding this comment.
@AA-Turner Good thinking, but there's several issues I spotted with it—
The email obfuscation (`_mask_email is getting (inconsistently) applied for the thread link display text, making it uglier and more difficult to visually parse, and this explicitly contradicts PEP 1 (even though it appears to be what the legacy code is currently doing, which appears to be unintentional as the rather outdated allow-list is not respected):
Note that email addresses in the Discussions-To header will not be obscured.
Furthermore, given the usages are merely the link text for a mailto link, which is even easier for spambots to programmatically parse, it makes little sense to do so here.
The fact that the visible link text is just an email address (obfuscated or not) lends itself to a clear point of confusion and uncertainty—as a user, when I see a linked email address, I expect it to be a mailto: link, not a HTTP URL to a thread on the web. Indeed, some links are mailto: (for those listing email lists) while others are https: (those to threads), with no way of users telling them apart and knowing what they go to, aside from hovering over each link and carefully reading it.
While this is the legacy behavior, the old mailto: links send a new email to the mailing list with a title of the PEP's number, which is neither terribly useful (the user must be a member of the list, it creates a new, fragmented thread, and doesn't help users looking to join or to view the current thread), nor in keeping with the new PEP 1/PEP 12 guidance.
To fix this issues, I suggest the following two changes:
I'd be happy to contribute and test them for your review, if you'd prefer. Just lmk.
Sorry, something went wrong.
Sorry I don't get this one -- https://python.github.io/peps/pep-0681/ seems to be fine?
Sure
Less sure on this, but I'll try it out and see. A |
Sorry, something went wrong.
Its obfuscated, at least for me: Meanwhile, PEP 683 is obfuscated... But PEP 677 is not, despite having the same list address on the allow-list, but a mailto rather than a thread link
As an alternative, for old-style direct emails, we could mirror the very common (as much if not more so than just the raw email address) List-Name <example@example.com> form, linking the list name to the list page, and the email with a mailto. Or, perhaps simpler and more practical, have the code convert this form to `List-Title <https://list.url>`_ to display consistently with the bare addresses. Additionally, it would be idea if the code could code is not parsing the very common List-Name < |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
xref #2344 (comment)
A