FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 654: add number of sub-exceptions to BaseException.__str__ by iritkatriel · Pull Request #2356 · python/peps · GitHub

Repository navigation

PEP 654: add number of sub-exceptions to BaseException.__str__ - #2356

Merged
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:eg-str
Feb 22, 2022
Merged

iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:eg-str

Conversation

Copy link
Copy Markdown
Member

No description provided.

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't see a reason to bother the SC with this level of detail. If they don't like this they can comment on the PR or open a new bpo.

iritkatriel marked this pull request as ready for review February 22, 2022 16:59

Copy link
Copy Markdown
Member

I don't see a reason to bother the SC with this level of detail. If they don't like this they can comment on the PR or open a new bpo.

This change looks fine from an editor perspective; would you like to keep it open for some time to allow the Council to comment or are you happy for it to be merged?

A

iritkatriel merged commit 4e06e44 into python:main Feb 22, 2022

Copy link
Copy Markdown
Member Author

Let's merge, we can always change it if there's an issue.

CAM-Gerlach changed the title PEP-654: add number of sub-exceptions to BaseException.__str__ PEP 654: add number of sub-exceptions to BaseException.__str__ Feb 22, 2022

CAM-Gerlach commented Feb 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Just FYI, @python/pep-editors , its probably a good idea to check for and fix PR titles to ensure they follow the standard PEP N: <desc> format, since that is what gets set as the commit message for the squashed commit, and its very quick and painless to do without bothering the PR author. PR #2352 includes better language for this in the Contributing Guide, making it clearer and more explicit that PR titles (as well as the commit summary lines already discussed) should follow the format, since the former get turned in to the latter (of course, it can be fixed on merge, but better and more reliable to do it before).

Copy link
Copy Markdown
Member

I normally do this when merging commits rather than changing the title, but I generally agree (to the extent of labelling most of my infrastructure PRs under PEP 676!)

A

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL