FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 655: Mark as accepted by JelleZijlstra · Pull Request #2451 · python/peps · GitHub

  1. python
  2. peps

Repository navigation

PEP 655: Mark as accepted - #2451

Merged
JelleZijlstra merged 1 commit into
mainfrom
JelleZijlstra-patch-1
Mar 22, 2022
ConversationCommits (1)ChecksFiles changed
Merged

PEP 655: Mark as accepted#2451
JelleZijlstra merged 1 commit into
mainfrom
JelleZijlstra-patch-1

Conversation

JelleZijlstra commented Mar 21, 2022

Copy link
Copy Markdown
Member

cc @davidfstr. Also, I opened https://bugs.python.org/issue47087 to track the CPython implementation, but couldn't find you there

PEP 655: Mark as accepted
81525ca 
cc @davidfstr. Also, I opened https://bugs.python.org/issue47087 to track the CPython implementation, but couldn't find you there
CAM-Gerlach approved these changes Mar 21, 2022
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks.

FYI, following standard GitHub flow and creating these branches in the fork rather than upstream will avoid running and displaying duplicate sets of checks (as well as cluttering the upstream branch list).

gpshead reviewed Mar 22, 2022
View reviewed changes
Comment thread pep-0655.rst
Created: 30-Jan-2021
Python-Version: 3.11
Post-History: 31-Jan-2021, 11-Feb-2021, 20-Feb-2021, 26-Feb-2021, 17-Jan-2022, 28-Jan-2022
Resolution: https://mail.python.org/archives/list/python-dev@python.org/message/AJEDNVC3FXM5QXNNW5CR4UCT4KI5XVUE/

gpshead Mar 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fyi the typing-sig version is https://mail.python.org/archives/list/typing-sig@python.org/thread/AJEDNVC3FXM5QXNNW5CR4UCT4KI5XVUE/ - the emails on this one were caught in moderation so they didn't appear at the same time ;) as discussion was on typing-sig, maybe link to that one?

CAM-Gerlach Mar 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, but the the Typing-SIG thread is already linked in the Discussions-To header, and Python-Dev is the canonical place to post (non-Packaging, given its SC-delegated authority) PEP resolutions per PEP 1, as most recently discussed in #2266 , implemented in #2346 and approved by the SC in python/steering-council#113:

Except where otherwise approved by the Steering Council, pronouncements of PEP resolution will be posted to the Python-Dev mailing list.

davidfstr commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

LGTM. 🥳

Now it's time to implement. @JelleZijlstra I did add myself as Nosy on the BPO item. I did look for a way to self-assign it since I'm guessing the implementation will fall to me but did not find a way.

JelleZijlstra merged commit 3b879dd into main Mar 22, 2022
JelleZijlstra deleted the JelleZijlstra-patch-1 branch March 22, 2022 15:49

JelleZijlstra commented Mar 22, 2022

Copy link
Copy Markdown
Member Author

@davidfstr it looks like BPO doesn't let me assign an issue to non-core devs, but please go ahead. If you don't have time I can help out with the implementation too; we just have to make sure it goes in before the feature freeze in about a month.

davidfstr commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

we just have to make sure it goes in before the feature freeze in about a month.

I'm tracking this key date very carefully. ^_^

erlend-aasland mentioned this pull request May 13, 2022
Closed
erlend-aasland mentioned this pull request Jun 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead left review comments
CAM-Gerlach CAM-Gerlach approved these changes
gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL