FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 623: Change status to Final by methane · Pull Request #2601 · python/peps · GitHub

  1. python
  2. peps

Repository navigation

PEP 623: Change status to Final - #2601

Merged
methane merged 3 commits into
python:mainfrom
methane:pep623
May 13, 2022
ConversationCommits (3)ChecksFiles changed
Merged

PEP 623: Change status to Final#2601
methane merged 3 commits into
python:mainfrom
methane:pep623

Conversation

methane commented May 12, 2022

Copy link
Copy Markdown
Member

Implemented in python/cpython#92537

AA-Turner approved these changes May 12, 2022
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I noticed that there is no Resolution header for the PEP.
We should add that either in this PR or a follow-up.

A

hugovk commented May 12, 2022

Copy link
Copy Markdown
Member

And a Discussions-To with https://mail.python.org/archives/list/python-dev@python.org/thread/S7KW2U6IGXZFBMGS6WSJB26NZIBW4OLE/ ?

CAM-Gerlach commented May 12, 2022

Copy link
Copy Markdown
Member

This thread is the resolution.

Its hard to be sure since the text is somewhat ambiguous and highly technical, but it sounds like that thread is not actually about PEP 623 itself, which concerns only the APIs using the wstr Unicode struct member, while the other APIs are stated to be out of scope by the PEP, whereas the thread is titled "Plan to remove Py_UNICODE APIs except PEP 623" and lists a different set of objects to be removed than the PEP does. However, I can't find any thread about PEP 623 either searching Python-Dev or Discourse. There's this thread on the related PEP 624, but that's a separate PEP.

Inada-san, could you help us out with a link to the thread? Or @vstinner ?

vstinner approved these changes May 12, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

methane merged commit 9111678 into python:main May 13, 2022
methane deleted the pep623 branch May 13, 2022 02:37
erlend-aasland mentioned this pull request May 13, 2022
Closed
erlend-aasland mentioned this pull request Jun 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
AA-Turner AA-Turner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL