FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Several PEPs: Add `Topic: Packaging` by AA-Turner · Pull Request #2636 · python/peps · GitHub

/ peps Public

Several PEPs: Add Topic: Packaging - #2636

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
AA-Turner:subindicies-packaging
Jun 14, 2022
ConversationCommits (3)ChecksFiles changed
Merged

Several PEPs: Add Topic: Packaging#2636
JelleZijlstra merged 3 commits into
python:mainfrom
AA-Turner:subindicies-packaging

Conversation

AA-Turner commented Jun 8, 2022

Copy link
Copy Markdown
Member

Depends on #2579

Opened as draft to not ping for review.

A

ghost commented Jun 8, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:

JelleZijlstra commented Jun 8, 2022

Copy link
Copy Markdown
Member

PEP-691 should also be included.

pradyunsg reviewed Jun 10, 2022
View reviewed changes

pradyunsg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This list looks great. I have a few suggestions for things to exclude. :)

Comment thread pep-0250.txt Outdated
Comment thread pep-0273.txt Outdated
Comment thread pep-0370.txt Outdated
Comment thread pep-0382.txt Outdated
Comment thread pep-0394.txt Outdated
Comment thread pep-0395.txt Outdated
Comment thread pep-0420.txt Outdated
Comment thread pep-0441.txt Outdated
Comment thread pep-3147.txt Outdated
Comment thread pep-3149.txt Outdated

AA-Turner commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

@JelleZijlstra -- if @pradyunsg is happy with the new list then this can be merged (the extra headers will do nothing for now).

A

AA-Turner changed the title Add Topic: Packaging for subindices Several PEPs: Add Topic: Packaging Jun 14, 2022

pradyunsg commented Jun 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

FYI: This is still draft, and the CLA check is failing.

AA-Turner commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

Draft: as making it ready to review will ping ~20 people.

CI Failing: As the CLA bot doesn't like me. @ambv is aware and doing his best to fix but for now a repo admin (Jelle) needs to merge. Computers can be such fun.

A

JelleZijlstra commented Jun 14, 2022

Copy link
Copy Markdown
Member

I can't merge it while it's a draft though. I suppose we'll have to ping them all briefly.

AA-Turner marked this pull request as ready for review June 14, 2022 21:20

AA-Turner commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

I can't merge it while it's a draft though. I suppose we'll have to ping them all briefly.

Oh that's annoying. I bit the bullet, hopefully GH is smart enough not to ping if the request is removed in <10 seconds.

A

JelleZijlstra merged commit 19f2582 into python:main Jun 14, 2022
zooba reviewed Jun 15, 2022
View reviewed changes
Comment thread pep-0632.rst
Discussions-To: https://discuss.python.org/t/pep-632-deprecate-distutils-module/5134
Status: Accepted
Type: Standards Track
Topic: Packaging

zooba Jun 15, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This PEP is standard library, not packaging. It doesn't say anything about what packaging projects should do, and restricts itself to the changes in the stdlib.

This was referenced Jun 18, 2022
Merged
Closed
Merged
erlend-aasland mentioned this pull request Jun 27, 2022
Closed
This was referenced Jul 1, 2022
Merged
Closed

This comment was marked as spam.

Sign in to view

ncoghlan mentioned this pull request Jul 16, 2026
Merged
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba left review comments
pradyunsg pradyunsg left review comments
+1 more reviewer
Codenamecodai Codenamecodai left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL