FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...' by hugovk · Pull Request #2809 · python/peps · GitHub

  1. python
  2. peps

Repository navigation

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...' - #2809

Merged
hugovk merged 8 commits into
python:mainfrom
hugovk:fix-author-format
Oct 5, 2022
ConversationCommits (8)ChecksFiles changed
Merged

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...'#2809
hugovk merged 8 commits into
python:mainfrom
hugovk:fix-author-format

Conversation

hugovk commented Oct 3, 2022

Copy link
Copy Markdown
Member

Prep for #2672.

  • Enable the validate-author check for .txt PEPs
  • Reformat the old email@example.com (Name) headers to Name <email@example.com>
  • Whilst editing those files, also remove the redundant emacs metadata
  • And fix the couple of footnote warnings in PEPs 3 and 231:
pep-0003.txt:72: WARNING: Footnote [1] is not referenced.
pep-0231.txt:616: WARNING: Footnote [8] is not referenced.

hugovk added bug infra Core infrastructure for building and rendering PEPs labels Oct 3, 2022
hugovk force-pushed the fix-author-format branch from 6066814 to 42f5a07 Compare October 4, 2022 22:08
hugovk requested a review from ncoghlan as a code owner October 4, 2022 22:08

hugovk commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

Updated with suggestions from CAM:

  • Infra: Remove redundant validate-author-legacy pre-commit check, now that validate-author runs for both rst and txt
  • PEP 1: Remove redundant sentence, now we only have the new author format
  • And whilst we're editing these files, also remove redundant Version and Last-Modified headers

hugovk removed the request for review from ncoghlan October 4, 2022 22:15
CAM-Gerlach approved these changes Oct 4, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM now, thanks @hugovk !

CAM-Gerlach removed the bug label Oct 4, 2022
hugovk merged commit 5fb8b28 into python:main Oct 5, 2022
hugovk deleted the fix-author-format branch October 5, 2022 16:48
hugovk mentioned this pull request Jan 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
Mariatta Mariatta approved these changes
CAM-Gerlach CAM-Gerlach approved these changes

Assignees

No one assigned

Labels

infra Core infrastructure for building and rendering PEPs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL