Add optional Connection.autocommit attribute to PEP 249 - #2887
Merged
malemburg merged 3 commits intoNov 16, 2022
Merged
malemburg merged 3 commits into
malemburg merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…IG ML. Fix the creation date to point to the announcement date of the DB-API 2.0. Add years to the acknowledgements. Minor editorial changes.
Copy link
Copy Markdown
Member
Author
|
Thanks for the review, @erlend-aasland |
Sorry, something went wrong.
erlend-aasland
approved these changes
Nov 16, 2022
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for the PEP update, Marc-André! LGTM
Sorry, something went wrong.
CAM-Gerlach
reviewed
Nov 17, 2022
Comment thread
pep-0249.txt
| @@ -5,7 +5,7 @@ Discussions-To: db-sig@python.org | |||
| Status: Final | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
If this PEP is Informational, shouldn't it be Active, givens the guidance within is presumably still valid, up to date and in-use rather than historical and frozen?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on the DB-SIG ML.
Fix the creation date to point to the announcement date of the DB-API 2.0.
Add years to the acknowledgements.
Minor editorial changes.