FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Lint: Fix outstanding codespell spelling errors by arhadthedev · Pull Request #3129 · python/peps · GitHub

  1. python
  2. peps

Repository navigation

Lint: Fix outstanding codespell spelling errors - #3129

Merged
hugovk merged 6 commits into
python:mainfrom
arhadthedev:codespell-fix
May 1, 2023
ConversationCommits (6)ChecksFiles changed
Merged

Lint: Fix outstanding codespell spelling errors#3129
hugovk merged 6 commits into
python:mainfrom
arhadthedev:codespell-fix

Conversation

arhadthedev commented Apr 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

https://github.com/python/peps/actions/runs/4843117521/jobs/8630554766?pr=3128#step:5:87:

Check for common misspellings in text files..............................Failed
- hook id: codespell
- exit code: 65

pep-0642.rst:1702: recenty ==> recently
pep-0205.txt:189: referencable ==> referenceable
pep-0205.txt:213: referencable ==> referenceable
pep-0205.txt:213: referencable ==> referenceable
pep-0582.rst:49: depenencies ==> dependencies
pep-0652.rst:245: aded ==> added
pep-0653.rst:596: stategy ==> strategy
pep-0701.rst:379: withing ==> within
pep-0701.rst:439: withing ==> within
pep-0011.txt:45: plaforms ==> platforms
pep-0622.rst:2110: equilvalent ==> equivalent
pep-0670.rst:524: retreive ==> retrieve
pep-0426.txt:1287: overal ==> overall
pep-0708.rst:126: similiar ==> similar
pep-0526.txt:467: undocummented ==> undocumented
pep-0665.rst:58: producting ==> producing, production
pep-0285.txt:418: redability ==> readability
pep-0683.rst:27: implmentation ==> implementation
pep-0683.rst:706: speicific ==> specific
pep-0677.rst:1023: ot ==> to, of, or, not
pep-0677.rst:1118: compatiblity ==> compatibility
pep-0689.rst:42: requring ==> requiring
pep-0689.rst:133: exeption ==> exception, exemption
pep-0691.rst:87: reponses ==> responses
pep-0669.rst:121: Ancilliary ==> Ancillary
pep-0669.rst:425: neglible ==> negligible
pep-0674.rst:404: sufficently ==> sufficiently
pep-0684.rst:674: allcoators ==> allocators
pep-0690.rst:296: dictionay ==> dictionary
pep-0706.rst:541: wth ==> with
pep-0706.rst:572: dilligent ==> diligent
pep-0554.rst:481: inteded ==> intended

📚 Documentation preview 📚: https://pep-previews--3129.org.readthedocs.build/

arhadthedev commented Apr 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I cannot uncheck reviewers added from CODEOWNERS so my apologises for making more noise than required.

arhadthedev marked this pull request as ready for review April 30, 2023 08:04

arhadthedev commented Apr 30, 2023

Copy link
Copy Markdown
Member Author

Correction: I can but only after creating and undrafting a PR.

arhadthedev changed the title Fix errors silently reported by Lint / Run pre-commit (pull_request) Fix errors reported silently by Lint / Run pre-commit (pull_request) Apr 30, 2023

AA-Turner commented Apr 30, 2023

Copy link
Copy Markdown
Member

To note, these were left unfixed in #3080, and we generally have a disinclination for mass typo-fix PRs. I'm not sure what the other editors think, though.

A

hugovk reviewed Apr 30, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Personally I'm fine with it, but as Adam said, we've generally avoided this sort of thing. And I recently suggested a typo fix to work around the repeated CI approval when iterating for a first-time contributor (#3095 (comment)).

But this PR is made now, we may as well merge it :)

Comment thread pep-0205.txt Outdated

arhadthedev commented Apr 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

we generally have a disinclination for mass typo-fix PRs

I hope it's a once-in-a-lifetime fix. After that, we can change .github/workflows/lint.yml to not allow new typos to creep in:

-          extra_args: --all-files --hook-stage manual codespell || true
+          extra_args: --all-files --hook-stage manual codespell

Edit: should I add the modification of lint.yml into this PR?

hugovk commented Apr 30, 2023

Copy link
Copy Markdown
Member

No thanks, when this was added, we didn't want to enforce spellcheck on CI due to false positives: #2075 (comment) / #2075 (comment) / #2151 (review) / #2151 (comment) / etc.

AA-Turner requested changes Apr 30, 2023
View reviewed changes
Comment thread pep-0205.txt Outdated
Comment thread pep-0205.txt Outdated
Comment thread pep-0669.rst Outdated
arhadthedev and others added 3 commits April 30, 2023 14:57
Add more exceptions
3643145
Apply suggestions from code review
64dc0e2 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ancillary -> ancilliary
1714d8b
arhadthedev requested a review from AA-Turner April 30, 2023 18:12
wookie184 suggested changes May 1, 2023
View reviewed changes
Comment thread pep-0677.rst Outdated
Update pep-0677.rst
5376172 
Co-authored-by: wookie184 <wookie1840@gmail.com>
wookie184 reviewed May 1, 2023
View reviewed changes
Comment thread pep-0689.rst
CAM-Gerlach changed the title Fix errors reported silently by Lint / Run pre-commit (pull_request) Lint: Fix outstanding codespell spelling errors May 1, 2023
CAM-Gerlach added lint Linter-related work and linting fixes on PEPs and removed enhancement labels May 1, 2023
CAM-Gerlach approved these changes May 1, 2023
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM now, though seems like others have already done the hard work of reviewing this. As others have mentioned, we don't really want to encourage these kind of mass-typo-fix PR, but we may as well merge it. Hopefully they will be less common now that #3080 was implemented, though that thought might be rather optimistic and this will be a perpetual problem.

hugovk merged commit b9ca714 into python:main May 1, 2023
arhadthedev deleted the codespell-fix branch May 1, 2023 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
hugovk hugovk approved these changes
AA-Turner AA-Turner approved these changes
CAM-Gerlach CAM-Gerlach approved these changes
+1 more reviewer
wookie184 wookie184 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lint Linter-related work and linting fixes on PEPs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL