FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 734: Multiple Interpreters in the Stdlib by ericsnowcurrently · Pull Request #3523 · python/peps · GitHub

Repository navigation

PEP 734: Multiple Interpreters in the Stdlib - #3523

Merged
ericsnowcurrently merged 87 commits into
python:mainfrom
ericsnowcurrently:pep-554-rewrite
Nov 28, 2023
Merged

ericsnowcurrently merged 87 commits into
python:mainfrom
ericsnowcurrently:pep-554-rewrite

Conversation

ericsnowcurrently commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--3523.org.readthedocs.build/pep-0734/

ericsnowcurrently changed the title PEP 734: PEP 734: Multiple Interpreters in the Stdlib Nov 7, 2023
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0554.rst
Comment thread peps/pep-0554.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi Eric, I know we already spoke about some of this off-line, but I ran out of time reviewing all my comments. I know the next revision will be much improved!

Comment thread peps/pep-0734.rst
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Comment thread peps/pep-0734.rst Outdated
Rosuav mentioned this pull request Nov 11, 2023
24 of 27 tasks

Copy link
Copy Markdown
Member Author

@gvanrossum, I've made updates to address your review comments. Thanks again for taking the time to provide such useful feedback. ❤️

I'm concerned that the PEP is getting a little too long, so let me know if there are any sections that you think are unnecessary or have too much detail, if you can spare me the time.

Copy link
Copy Markdown
Member Author

FYI, once this PR is merged, I plan on updating the implementation (and update some benchmarks, to try it out) before posting the PEP for discussion. That way I can tweak the PEP if something doesn't feel right in practice.

Copy link
Copy Markdown
Member

Are you awaiting more review from me? Im in Japan but can make a little time.

Copy link
Copy Markdown
Member Author

Sweet of you to offer, but no. If needed, we can chat when you are back.

Copy link
Copy Markdown
Member Author

There are probably a handful of things to tweak, like trim back some of the fluff, but I'll do that in follow-up PRs.

ericsnowcurrently merged commit 6aeaba7 into python:main Nov 28, 2023
ericsnowcurrently deleted the pep-554-rewrite branch November 28, 2023 02:32
hugovk added the new-pep A new draft PEP submitted for initial review label Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL