PEP 675: Mark malicious code example with red sidebar - #3574
Merged
ambv merged 3 commits intoDec 11, 2023
Merged
ambv merged 3 commits into
ambv merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Nice. This is a great feature to be able to roll out. |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Dec 10, 2023
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@pradeep90 as an FYI
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Updated to include some more from @Jamim: hugovk#7 @Jamim Please could you sign the CLA? #3574 (comment) Screenshots
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sure! I've signed the CLA. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes python/docs-community#22.
As suggested by @encukou in python/docs-community#22, the dangerous "naive" SQL code could do with a red marker.
Regarding accessibility, similar to #3567, we're not relying on colour to convey meaning, it's also there in the text. ✅
Are there any examples in this PEP that could benefit from a red or green (or even yellow) sidebar? Perhaps the "written safely" one immediately after could be green?
Also remove the redundant headers.
📚 Documentation preview 📚: https://pep-previews--3574.org.readthedocs.build/