PEP 7: Remove Python 2.2 advice, add C syntax highlighting and green/red sidebars - #3702
Merged
hugovk merged 6 commits intoMar 29, 2024
Merged
hugovk merged 6 commits into
hugovk merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
approved these changes
Mar 3, 2024
Jamim
approved these changes
Mar 16, 2024
willingc
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the section "For C code that needs to support versions of Python older than 2.3...". I can add it back if needed.
Highlight the example C code with C syntax instead of Python.
Like PEP 8 (PEP 8: Add green and red sidbar for good and bad examples #3567), add green and red side borders "good" and "bad" examples. For this, I split this example into two blocks:
Example
📚 Documentation preview 📚: https://pep-previews--3702.org.readthedocs.build/pep-0007/