Infra: Add Sponsor to the PEPs API - #4804
Open
Secrus wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Secrus
force-pushed
the
add-sponsor-to-api
branch
from
550a6c9 to
139ad22
Compare
February 3, 2026 13:21
Secrus
marked this pull request as draft
February 3, 2026 13:22
Secrus
force-pushed
the
add-sponsor-to-api
branch
3 times, most recently
from
c794e17 to
2680d2c
Compare
February 3, 2026 13:34
Secrus
force-pushed
the
add-sponsor-to-api
branch
from
2680d2c to
8d14d70
Compare
February 3, 2026 13:37
Secrus
marked this pull request as ready for review
February 3, 2026 13:40
johnslavik
reviewed
Feb 8, 2026
johnslavik
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! Some thoughts.
Sorry, something went wrong.
Comment thread
pep_sphinx_extensions/pep_zero_generator/parser.py
Comment on lines
+21
to
+38
| _frozen_ordered = dataclasses.dataclass(order=True, frozen=True) | ||
|
|
||
|
|
||
| @_frozen_ordered | ||
| class _Participant: | ||
| """Represent PEP participant.""" | ||
| full_name: str # The participant's name. | ||
| email: str # The participant's email address. | ||
|
|
||
|
|
||
| @_frozen_ordered | ||
| class _Author(_Participant): | ||
| """Represent PEP authors.""" | ||
| full_name: str # The author's name. | ||
| email: str # The author's email address. | ||
|
|
||
|
|
||
| @_frozen_ordered | ||
| class _Sponsor(_Participant): | ||
| """Represent PEP sponsors.""" |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Consider not creating an alias here, obeying the locality of behavior rule (LoB) and keeping separate classes slightly more self-contained. Consider using dataclasses.field(doc=...).
Suggested change
| _frozen_ordered = dataclasses.dataclass(order=True, frozen=True) | |
| @_frozen_ordered | |
| class _Participant: | |
| """Represent PEP participant.""" | |
| full_name: str # The participant's name. | |
| email: str # The participant's email address. | |
| @_frozen_ordered | |
| class _Author(_Participant): | |
| """Represent PEP authors.""" | |
| full_name: str # The author's name. | |
| email: str # The author's email address. | |
| @_frozen_ordered | |
| class _Sponsor(_Participant): | |
| """Represent PEP sponsors.""" | |
| @dataclasses.dataclass(order=True, frozen=True) | |
| class _Participant: | |
| """Represent PEP participant.""" | |
| full_name: str = dataclasses.field(doc="The participant's name.") | |
| email: str = dataclasses.field(doc="The participant's email address.") | |
| @dataclasses.dataclass(order=True, frozen=True) | |
| class _Author(_Participant): | |
| """Represent PEP authors.""" | |
| full_name: str = dataclasses.field(doc="The author's name.") | |
| email: str = dataclasses.field(doc="The author's email address.") | |
| @dataclasses.dataclass(order=True, frozen=True) | |
| class _Sponsor(_Participant): | |
| """Represent PEP sponsors.""" |
Sorry, something went wrong.
Comment thread
pep_sphinx_extensions/pep_zero_generator/parser.py
Comment on lines
+221
to
+230
|
|
||
|
|
||
|
|
||
| def _parse_author(data: str) -> list[_Author]: | ||
| """Return a list of author names and emails.""" | ||
| return [_Author(author, email) for author, email in _parse_participants(data)] | ||
|
|
||
| def _parse_sponsor(data: str) -> _Sponsor: | ||
| """Return sponsor name and email""" | ||
| return _Sponsor(*_parse_participants(data)[0]) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Formatting nits
Suggested change
| def _parse_author(data: str) -> list[_Author]: | |
| """Return a list of author names and emails.""" | |
| return [_Author(author, email) for author, email in _parse_participants(data)] | |
| def _parse_sponsor(data: str) -> _Sponsor: | |
| """Return sponsor name and email""" | |
| return _Sponsor(*_parse_participants(data)[0]) | |
| def _parse_author(data: str) -> list[_Author]: | |
| """Return a list of author names and emails.""" | |
| return [_Author(author, email) for author, email in _parse_participants(data)] | |
| def _parse_sponsor(data: str) -> _Sponsor: | |
| """Return sponsor name and email""" | |
| return _Sponsor(*_parse_participants(data)[0]) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Sponsor information to the PEP details, targeted mostly for API access
📚 Documentation preview 📚: https://pep-previews--4804.org.readthedocs.build/