FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 661: Amend to allow two customizations by JelleZijlstra · Pull Request #4968 · python/peps · GitHub

  1. python
  2. peps

Repository navigation

PEP 661: Amend to allow two customizations - #4968

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:pep661-custom
May 19, 2026
ConversationCommits (2)ChecksFiles changed
Merged

PEP 661: Amend to allow two customizations#4968
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:pep661-custom

Conversation

JelleZijlstra commented May 10, 2026

Copy link
Copy Markdown
Member

These are changes I'd like to make during the beta phase (I'll post asking for SC approval).

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

JelleZijlstra requested a review from taleinat as a code owner May 10, 2026 22:48

read-the-docs-community Bot commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #32627747 | 📁 Comparing 7dd698f against latest (0cde95d)

  🔍 Preview build  

699 files changed · ± 699 modified

± Modified

JelleZijlstra mentioned this pull request May 10, 2026
Merged

taleinat commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Both of these, customizable repr and setting __module__, were in earlier versions of the PEP and make sense.

Regarding making repr customizable by passing in an argument, LGTM.

Regarding making __module__ writeable, I find that a bit surprising. Have you considered adding another argument to sentinel()? That would be more in line with namedtuple and Enum which do this for similar reasons, and be more in line with sentinels being immutable. (I see Kyle made a similar comment in the PEP discussion.)

JelleZijlstra commented May 19, 2026

Copy link
Copy Markdown
Member Author

The SC approved this change.

JelleZijlstra merged commit 7dd79b1 into python:main May 19, 2026
5 checks passed
JelleZijlstra added a commit to python/cpython that referenced this pull request May 19, 2026
gh-148829: Make sentinels' repr and module customizable (#149654)
0821803 
Implementation of python/peps#4968; still needs SC approval.
miss-islington mentioned this pull request May 19, 2026
Merged
JelleZijlstra added a commit to python/cpython that referenced this pull request May 22, 2026
[3.15] gh-148829: Make sentinels' repr and module customizable (GH-14…
f523146 
…9654) (#150092)

Implementation of python/peps#4968.
(cherry picked from commit 0821803)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
ethanfurman pushed a commit to ethanfurman/peps that referenced this pull request Oct 8, 2026
PEP 661: Amend to allow two customizations (python#4968)
6d8bb83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

taleinat Awaiting requested review from taleinat taleinat is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL