FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 843: Address comments by NeilGirdhar · Pull Request #5106 · python/peps · GitHub

/ peps Public

PEP 843: Address comments - #5106

Merged
ZeroIntensity merged 1 commit into
python:mainfrom
NeilGirdhar:comments
Aug 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

PEP 843: Address comments#5106
ZeroIntensity merged 1 commit into
python:mainfrom
NeilGirdhar:comments

Conversation

NeilGirdhar commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Consolidated the __all__-normalization pseudocode into a single copy in
    Specification_, instead of repeating it three times.
  • Added an Open Issues section asking whether export should raise a
    DeprecationWarning on a non-list __all__.
  • Cited the canonical definition of DRY.
  • Restricted export to module level.

I also fixed the formatting to agree with PEP 12. (Sorry for the long diff.)

NeilGirdhar changed the title PEP 843: Address open question and reviewer feedback PEP 843: Add citation Aug 22, 2026

read-the-docs-community Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #34190463 | 📁 Comparing 7da32a1 against latest (0363920)

  🔍 Preview build  

1 file changed
± pep-0843/index.html

NeilGirdhar marked this pull request as draft August 22, 2026 21:05

NeilGirdhar commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

Hold on, I'm going to address Jorenham's comment

NeilGirdhar marked this pull request as ready for review August 22, 2026 21:26
NeilGirdhar marked this pull request as draft August 22, 2026 21:28
NeilGirdhar force-pushed the comments branch 2 times, most recently from cf71515 to 846f982 Compare August 22, 2026 21:32
NeilGirdhar marked this pull request as ready for review August 22, 2026 21:32

hugovk commented Aug 22, 2026

Copy link
Copy Markdown
Member

Could you also include "DRY (don't repeat yourself)" for the first DRY mention in prose?

NeilGirdhar commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

@hugovk Good idea, will do

PEP 843: Address comments
7da32a1 
- Consolidated the ``__all__``-normalization pseudocode into a single copy in
`Specification`_, instead of repeating it three times.
- Added an Open Issues section asking whether ``export`` should raise a
``DeprecationWarning`` on a non-list ``__all__``.
- Cited the canonical definition of DRY.
- Restricted ``export`` to module level.
NeilGirdhar changed the title PEP 843: Add citation PEP 843: Address comments Aug 23, 2026

ZeroIntensity commented Aug 23, 2026

Copy link
Copy Markdown
Member

All ready here?

ZeroIntensity commented Aug 23, 2026

Copy link
Copy Markdown
Member

Also, again, please don't rewrite your commit history and force-push. It makes reviewing harder, and we squash this all into one commit when merging anyway.

NeilGirdhar commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yes, ready!

ZeroIntensity merged commit 98aa0e5 into python:main Aug 23, 2026
5 checks passed
NeilGirdhar deleted the comments branch August 24, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL