PEP 835: address Jelle and Carl's feedback - #5181
Open
till-varoquaux wants to merge 1 commit into
Open
till-varoquaux wants to merge 1 commit into
till-varoquaux wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Documentation build overview1 file changed ± pep-0835/index.html |
Sorry, something went wrong.
Comment thread
peps/pep-0835.rst
| ``builtins.type`` in Typeshed will be updated to include | ||
| ``def __matmul__(self, other: Any) -> types.AnnotatedType: ...`` to support type | ||
| checkers. | ||
| ``def __matmul__(self, other: Any) -> Self: ...`` to support type checkers. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
hm why Self? That seems incorrect since it returns an instance of Annotated, not of type
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.