FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: remove perms by JacobCoffee · Pull Request #515 · python/psf-salt · GitHub

  1. python
  2. psf-salt

Repository navigation

ci: remove perms - #515

Open
JacobCoffee wants to merge 1 commit into
mainfrom
fix-ci-reminder
ConversationCommits (1)ChecksFiles changed
Open

ci: remove perms#515
JacobCoffee wants to merge 1 commit into
mainfrom
fix-ci-reminder

Conversation

JacobCoffee commented Oct 10, 2024

Copy link
Copy Markdown
Member

Description

  • remove perms from deployminder after testing a bunch on a private repo.

JacobCoffee requested a review from ewdurbin as a code owner October 10, 2024 17:28
JacobCoffee commented Oct 10, 2024
View reviewed changes
Comment thread .github/workflows/deployminder.yml
issues: write
steps:
- name: Comment on PR
uses: actions/github-script@v7

JacobCoffee Oct 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

maybe should revert to v6

ewdurbin Oct 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ah, was it working before update?

ewdurbin Oct 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doesn't look like we were ever using v6?

JacobCoffee Oct 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

im not sure anymore :\ this works on a private repo as many times as i can trigger it, but here it fails. both repos have the same perms in settings > actions, so im just confused on what the issue is.

it was working before the permissions add, then it wasn't

JacobCoffee Oct 10, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

going off of https://github.com/actions/github-script?tab=readme-ov-file#comment-on-an-issue and https://github.com/litestar-org/litestar/blob/119169d1c335f68cbc4673006b4cb2aa96983513/.github/workflows/pr-merged.yml#L49

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ewdurbin ewdurbin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL