FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adds 60 second disk cache for unauthenticated indexes. by zooba · Pull Request #111 · python/pymanager · GitHub

  1. python
  2. pymanager

Repository navigation

Adds 60 second disk cache for unauthenticated indexes. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zooba wants to merge 2 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 2 Checks 3 Files changed
Open

Adds 60 second disk cache for unauthenticated indexes. #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c835a4b
Adds 60 second disk cache for unauthenticated indexes.
zooba May 16, 2025
4c24176
Merge branch 'main' into gh-72
zooba Oct 17, 2025
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion src/manage/install_command.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def _find_one(cmd, source, tag, *, installed=None, by_id=False):
else:
LOGGER.verbose("Searching for default Python version")

downloader = IndexDownloader(source, Index, {}, DOWNLOAD_CACHE)
downloader = IndexDownloader(source, Index, {}, DOWNLOAD_CACHE, None if cmd.force else cmd.download_dir)
install = select_package(downloader, tag, cmd.default_platform, by_id=by_id)

if by_id:
Expand Down
2 changes: 1 addition & 1 deletion src/manage/list_command.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def execute(cmd):
if source:
try:
installs = _get_installs_from_index(
IndexDownloader(source, Index),
IndexDownloader(source, Index, disk_cache=cmd.download_dir),
tags,
)
break
Expand Down
35 changes: 34 additions & 1 deletion src/manage/urlutils.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -625,20 +625,46 @@ def is_valid_url(url):


class IndexDownloader:
def __init__(self, source, index_cls, auth=None, cache=None):
def __init__(self, source, index_cls, auth=None, cache=None, disk_cache=None):
self.index_cls = index_cls
self._url = source.rstrip("/")
if not self._url.casefold().endswith(".json".casefold()):
self._url += "/index.json"
self._auth = auth if auth is not None else {}
self._cache = cache if cache is not None else {}
self._disk_cache = Path(disk_cache) if disk_cache is not None else None
self._urlopen = urlopen
self._used_auth = False

def _use_disk_cache(self, url, data=None):
if not self._disk_cache:
return None
try:
if extract_url_auth(url):
return None
except OSError:
return None
from hashlib import sha256
from time import time
path = self._disk_cache / (sha256(url.encode("utf-8", "unicodeescape")).hexdigest() + ".cache")
if data:
path.parent.mkdir(parents=True, exist_ok=True)
path.write_bytes(data)
return
try:
if time() - path.lstat().st_mtime < 60:
return path.read_bytes()
path.unlink()
return None
except OSError:
return None

def __iter__(self):
return self

def on_auth(self, url):
# TODO: Try looking for parent paths from URL
self._used_auth = True
try:
return self._auth[url]
except LookupError:
Expand All @@ -658,14 +684,21 @@ def __next__(self):
except LookupError:
data = None

data = self._use_disk_cache(url)
if data:
LOGGER.debug("Fetched from disk cache")

if not data:
try:
self._used_auth = False
data = self._cache[url] = self._urlopen(
url,
"GET",
{"Accepts": "application/json"},
on_auth_request=self.on_auth,
)
if not self._used_auth:
self._use_disk_cache(url, data)
except FileNotFoundError: # includes 404
LOGGER.error("Unable to find runtimes index at %s", sanitise_url(url))
raise
Expand Down
Back | FazBrowse Home | New Git URL