Rework alias linking to ensure links are only created within bin directory - #277
zooba merged 5 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This pull request fixes broken executables in the Python bin directory by reworking the alias linking mechanism to ensure hard links are only created within the bin directory itself, rather than linking to files in the Python installation directory.
Changes:
- Modified alias creation logic to search for existing launchers within the bin directory for hard linking instead of linking directly to installation directory files
- Added support for the force flag to unconditionally recreate aliases
- Updated test expectations to reflect new debug log messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/manage/aliasutils.py | Refactored _create_alias function to search for existing launchers in the bin directory and link to those instead of linking to installation files, avoiding cross-directory linking issues |
| tests/test_alias.py | Added force = False attribute to test Cmd class and updated test assertions to match new logging behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fixes #258