Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR adds signed-index verification for runtime feed JSONs, aiming to detect tampering of the python.org index while keeping the feature configurable for other sources (Fixes #308).
Changes:
- Introduces a Windows native _native.verify_trust implementation to validate a JSON file against a signed catalog (.cat) using OS trust.
- Extends IndexDownloader to fetch and validate {index_url}.cat before processing indexes, with configurable per-source requirements (source_settings).
- Updates CI pipelines to generate/sign catalog files for partitioned indexes and upload the resulting .json.cat artifacts; adds tests and test fixtures.
Reviewed changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file| File | Description |
|---|---|
| tests/test_verify.py | Adds end-to-end tests covering successful verification and failure/bypass paths. |
| tests/data/self-signed.cat | Adds an untrusted (self-signed) catalog fixture for negative tests. |
| tests/data/psf-signed.cat | Adds a trusted/signed catalog fixture for positive tests. |
| tests/data/index-windows.json | Adds a test index fixture used by verification tests. |
| src/pymanager.json | Adds default source_settings for python.org index URLs. |
| src/manage/urlutils.py | Implements signature download/verification flow in IndexDownloader. |
| src/manage/list_command.py | Updates call sites for new IndexDownloader(cmd, ...) signature. |
| src/manage/install_command.py | Updates call sites for new IndexDownloader(cmd, ...) signature. |
| src/manage/indexutils.py | Extends index schema with signature-related fields. |
| src/manage/exceptions.py | Adds an exit code to InvalidFeedError for CLI handling. |
| src/manage/commands.py | Adds source_settings to config schema and command attributes. |
| src/manage/init.py | Treats InvalidFeedError as a user-facing error with an exit code. |
| src/_native/verify_trust.cpp | Adds native Windows verification logic for signed catalog + file hash membership. |
| scripts/repartition-index.py | Updates for new IndexDownloader constructor signature. |
| ci/upload.py | Uploads .json.cat alongside .json for index publishing. |
| ci/sign-files.yml | Adds reusable signing template used by pipelines. |
| ci/repartition-index.yml | Generates catalogs for index JSONs, signs them, and handles publish vs pretend-publish paths. |
| ci/release.yml | Refactors signing parameters and uses sign-files.yml; restructures post-test and publish stages. |
| _msbuild_test.py | Links wintrust.lib and exports verify_trust for test builds. |
| _msbuild.py | Links wintrust.lib and exports verify_trust for production builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
src/manage/urlutils.py
Outdated
Comment thread
ci/release.yml
Comment thread
src/manage/urlutils.py
Outdated
Comment thread
src/manage/commands.py
Comment thread
src/manage/indexutils.py
Outdated
Comment thread
src/manage/urlutils.py
Comment thread
src/_native/verify_trust.cpp
Outdated
Comment thread
src/_native/verify_trust.cpp
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308