Fixes welcome message and alias display - #417
Merged
zooba merged 3 commits intoSep 15, 2026
Merged
zooba merged 3 commits into
zooba merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
🟡 Changes recommended
Welcome messaging can use the host architecture instead of the configured default platform.
Get a fresh assessment by requesting another Copilot review.
Pull request overviewUpdates welcome messaging and platform-aware alias display, with Ruff configuration cleanup.
Changes:
- Adds changelog and ARM64-specific welcome messages.
- Formats aliases relative to the configured default platform.
- Updates related tests and Ruff settings.
| File | Summary |
|---|---|
| tests/test_list.py | Updates alias display expectations. |
| tests/test_installs.py | Tests default-platform alias formatting. |
| tests/test_install_command.py | Updates command test platform setup. |
| src/manage/scriptutils.py | Removes an unused exception binding. |
| src/manage/installs.py | Implements platform-aware alias formatting. |
| src/manage/install_command.py | Passes the configured platform to alias formatting. |
| src/manage/commands.py | Adds changelog and platform-specific welcome messages. |
| ruff.toml | Configures ignored Ruff rules. |
Suppressed comments (1)
src/manage/commands.py:548
- The new architecture-specific branch is not covered by the test suite: tests/conftest.py sets commands.WELCOME = "", so show_welcome() returns before this line in every test, and no test exercises either architecture-specific message. Please add focused coverage that mocks the architecture and verifies both the ARM64 and non-ARM64 messages.
if get_processor_architecture() == "-arm64":
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
src/manage/commands.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds ruff.toml to exclude noisy rules.