FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add tomli_loads benchmark by kumaraditya303 · Pull Request #200 · python/pyperformance · GitHub

  1. python
  2. pyperformance

Repository navigation

Add tomli_loads benchmark - #200

Merged
kumaraditya303 merged 12 commits into
python:mainfrom
kumaraditya303:tomllib
Apr 7, 2023
ConversationCommits (12)ChecksFiles changed
Merged

Add tomli_loads benchmark#200
kumaraditya303 merged 12 commits into
python:mainfrom
kumaraditya303:tomllib

Conversation

kumaraditya303 commented May 14, 2022

Copy link
Copy Markdown
Contributor

No description provided.

kumaraditya303 commented May 14, 2022

Copy link
Copy Markdown
Contributor Author

It seems like requires-python = ">=3.11" has no effect and seems broken.

kumaraditya303 marked this pull request as ready for review May 14, 2022 08:14
ericsnowcurrently requested changes May 24, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for working on this! It mostly LGTM. There's only one thing I'd like added.

Comment thread pyperformance/data-files/benchmarks/bm_tomllib_loads/run_benchmark.py Outdated
ericsnowcurrently approved these changes May 27, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Thanks for working on this.

Comment thread pyperformance/data-files/benchmarks/bm_tomllib_loads/generate_data.py Outdated
Update pyperformance/data-files/benchmarks/bm_tomllib_loads/generate_…
1f27ef1 
…data.py

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently removed their assignment Jun 10, 2022

ericsnowcurrently commented Jun 10, 2022

Copy link
Copy Markdown
Member

We can merge this once the tests are passing. Do you know what the problem is?

kumaraditya303 commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

See #200 (comment)

The issue is that requires-python metadata has no effect.

ericsnowcurrently commented Jun 10, 2022

Copy link
Copy Markdown
Member

Ah, right. I'll take a look at that real quick and then merge it.

mdboom commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Maybe we should have this install toml from PyPI instead of only using the stdlib one? That would give us more Python version coverage.

hauntsaninja commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

(tomllib is based on pypi's tomli, not toml)

AlexWaygood mentioned this pull request Mar 1, 2023
Open
kumaraditya303 changed the title Add tomllib.loads benchmark Add tomli_loads benchmark Apr 7, 2023
kumaraditya303 merged commit 9c58774 into python:main Apr 7, 2023
kumaraditya303 deleted the tomllib branch April 7, 2023 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL