Fix function to get if pyperformance is installed in editable mode - #369
mdboom merged 1 commit into
Conversation
Sorry, something went wrong.
This is used in compile.py: compile_all installs pyperformance for every version it compiles. If the main pyperformance is installed in editable mode, this should be propagated down. The mechamism to do that was broken because was checking the presence of setup.py, now long gone.
mdboom
left a comment
There was a problem hiding this comment.
LGTM, but someone who has used it in this mode more than I have should probably also weigh in ... (@ericsnowcurrently, @vstinner...?)
Sorry, something went wrong.
|
I don't recall enough about this to be useful. I'm sure Diego's fix is okay. |
Sorry, something went wrong.
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Yes, this is one of the thing that is useful only if you use a specific feature of the tool. @mdboom keeps saying that they don't use the compile_all at all, maybe it's time for me to move away from it. Thanks for approving. |
Sorry, something went wrong.
This is used in compile.py: compile_all installs pyperformance for every version it compiles. If the main pyperformance is installed in editable mode, this should be propagated down.
The mechamism to do that was broken because was checking the presence of setup.py, now long gone.