Fix _is_dev_install by using importlib.metadata API - #371
Merged
mdboom merged 1 commit intoNov 26, 2024
Merged
mdboom merged 1 commit into
mdboom merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Instead of checking the presence of files in the filesystem, use the importlib.metadata API to check if the installation is in editable mode.
mdboom
approved these changes
Nov 26, 2024
mdboom
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
FFY00
approved these changes
Nov 26, 2024
Copy link
Copy Markdown
Member
|
This relies on the assumption the build system implements PEP 610, but that's reasonable. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@FFY00 that's correct! I thought using a more standard way to do it. Anyway this check is very specific to pyperformance and it is not generic for a random package, so it should be pretty safe to use it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking the presence of files in the filesystem, use the importlib.metadata API to check if the installation is in editable mode.
Fix related to #319