| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
They were not added here in #341 for no reasons.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
cc @mdboom in case there was a reason to omit them. |
Sorry, something went wrong.
|
Ah, pypy3 failure seems relevant. decimal_factorial looks too slow on PyPy3 (with only pure-Python version of the decimal module). |
Sorry, something went wrong.
|
@hugovk, anything else? I think we can enable decimal_factorial test, but this will need a workaround for pure-Python decimal module. The presence of accelerated module we can detect, trying to import the _decimal module.
|
Sorry, something went wrong.
Tested locally with modified Modules/_decimal/tests/bench.py: n = 1000 pydecimal: calculation time: 3.147357s conversion time: 0.000016s int: calculation time: 0.001096s conversion time: 0.000271s n = 5000 pydecimal: calculation time: 15.728110s conversion time: 0.000014s int: calculation time: 0.009037s conversion time: 0.006705s
|
Ok, adapted version of the factorial benchmark works with pure-Python module. Timings (from CI): 287 ms on CPython 3.14 vs 2.36 sec on PyPy. Edit: with the patch for python/cpython#140036 I got following on decimal_factorial benchmark with pure-Python class: $ ./python Modules/_decimal/tests/bench.py # ====================================================================== # Factorial # ====================================================================== n = 100000 cdecimal: calculation time: 26.301405s conversion time: 0.000021s int: calculation time: 0.809898s conversion time: 0.441830s n = 1000000 cdecimal: calculation time: 397.983149s conversion time: 0.000115s int: calculation time: 39.675428s conversion time: 10.546071s So, probably we will have to adjust numbers anyway. |
Sorry, something went wrong.
|
Sorry, I'm not working on pyperformance anymore. It's uneasy for me to judge if this benchmark would be a good addition and it would measure correctly the big integer/decimal peerformance. |
Sorry, something went wrong.
|
The problem is that there is no decimal benchmarks at all. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
They were not added here in #341 for no reasons.