Add a benchmark for the Azure CLI. - #90
Open
ericsnowcurrently wants to merge 13 commits into
Open
ericsnowcurrently wants to merge 13 commits into
ericsnowcurrently wants to merge 13 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
7 of 8 tasks
Copy link
Copy Markdown
Member
Author
|
Hmm... Execute: 'C:\Users\RUNNER~1\AppData\Local\Temp\tmpg12c4haj\Scripts\python.exe' -m azdev setup --cli 'D:\a\pyperformance\pyperformance\pyperformance\benchmarks\data\azure-cli' Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python Python runtime state: preinitialized |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
FYI, using azure-cli on 3.9+ is currently blocked: Azure/azure-cli#16611. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of CPython performance work that @gvanrossum and I are starting. We want to use pyperformance to run our benchmarks (and profiling, but that's a separate issue). As there isn't a mechanism to plug in custom benchmarks, I'm putting up this PR.
I suppose there's the question of whether this is an appropriate benchmark for the suite. I think so. It represents a workload, based on concrete usage patterns for a widely used CLI app, that does not seem to be covered by other benchmarks. Note that at the moment I'm cheating a little by running tests out of the azure-cli test suite. However, I expect the tests exercise the code in a very similar way to common usage of the actual application. If there are concerns about inclusion I'm fine with leaving it out.
We will be using this benchmark (and a few others we will probably add) extensively.
(Either way, it would still be nice to have a way to plug in custom benchmarks externally. See #89.)