FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix problem with monospace rendering in Vivaldi by ZedThree · Pull Request #104 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Fix problem with monospace rendering in Vivaldi - #104

Merged
hugovk merged 1 commit into
python:mainfrom
ZedThree:fix-monospace-vivaldi
Feb 6, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Fix problem with monospace rendering in Vivaldi#104
hugovk merged 1 commit into
python:mainfrom
ZedThree:fix-monospace-vivaldi

Conversation

ZedThree commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

Fixes #98

ghost commented Jan 30, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

ezio-melotti reviewed Jan 30, 2023
View reviewed changes

ezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What browsers have you tested this with?
Do we know why the quoted `"monospace" was included and should we keep it somewhere in the list?

hugovk commented Jan 31, 2023

Copy link
Copy Markdown
Member

Quoted "monospace" was added in #85 to workaround a Chrome bug, which was fixed in Chrome 96 (Nov 2021): python/pythondotorg#1708 (comment).

By now, there's very little usage of Chrome 96 and older versions. Chrome 96% is 0.04% at https://caniuse.com/usage-table, and it's something like 1.68% for 96 and older.

(It would be good if we could hook up PR previews on Read the Docs or Netlify, that would make testing easier.)

ZedThree commented Jan 31, 2023

Copy link
Copy Markdown
Contributor Author

I tested with Vivaldi 5.6.2867.62 and Firefox 109.0

hugovk approved these changes Jan 31, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested building CPython docs locally using:

diff --git a/Doc/requirements.txt b/Doc/requirements.txt
index 134f39d6d7..c6d9c6a663 100644
--- a/Doc/requirements.txt
+++ b/Doc/requirements.txt
@@ -12,4 +12,4 @@ sphinxext-opengraph>=0.7.1
 
 # The theme used by the documentation is stored separately, so we need
 # to install that as well.
-python-docs-theme>=2022.1
+git+https://github.com/ZedThree/python-docs-theme@fix-monospace-vivaldi#egg=python-docs-theme

Looks fine on macOS Ventura 13.1 and Chrome 108:

And Safari 16.2:

And Firefox 109:

And Opera 93:

hugovk commented Jan 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

And I've put a preview build up at https://hugovk-cpython.readthedocs.io/en/python-docs-theme-pr-104/ if anyone else wants to test it.

Looks fine with Chrome 109 on Samsung S10 with Android 12.

hugovk merged commit f769cf3 into python:main Feb 6, 2023

hugovk commented Feb 6, 2023

Copy link
Copy Markdown
Member

Thank you!

ZedThree deleted the fix-monospace-vivaldi branch February 6, 2023 09:37
hugovk mentioned this pull request Mar 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti ezio-melotti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weird monospace bug

3 participants

Back | FazBrowse Home | New Git URL