FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add matrix strategy to test with all supported Python versions by m-aciek · Pull Request #114 · python/python-docs-theme · GitHub

Repository navigation

Add matrix strategy to test with all supported Python versions - #114

Merged
pradyunsg merged 1 commit into
python:mainfrom
m-aciek:test-on-all-py-versions
Mar 11, 2023
Merged

pradyunsg merged 1 commit into
python:mainfrom
m-aciek:test-on-all-py-versions

Conversation

m-aciek commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

ghost commented Mar 11, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

Copy link
Copy Markdown
Member

I'll go ahead and merge this, on the basis that this seems like a good idea overall. Holler if you spot something off! :)

pradyunsg merged commit 932b987 into python:main Mar 11, 2023

hugovk commented Mar 11, 2023

Copy link
Copy Markdown
Member

Is it possible to add 3.12/main?

Should the doc-html artifact at https://github.com/python/python-docs-theme/actions/runs/4393087253 also include 3.8-3.10?

Left is main, right is this PR:

m-aciek deleted the test-on-all-py-versions branch March 11, 2023 19:47

m-aciek commented Mar 11, 2023

Copy link
Copy Markdown
Contributor Author

Is it possible to add 3.12/main?

Yes, definitely, I think it's a good idea, I can add a pull request for that.

Should the doc-html artifact at https://github.com/python/python-docs-theme/actions/runs/4393087253 also include 3.8-3.10?

Actually, we should see the jobs for 3.8-3.10 as failed, as my branch wasn't basing on fresh-fixed master. The missing artifacts were because of failed jobs. It looks like exit code of build_docs.py script is incorrectly zero instead of non-zero for failing build. I will try to confirm that and follow it up in builddocs-script GitHub repository.

That's what the artifacts from the Actions on the theme main branch look like for me (all versions from matrix are there):

m-aciek commented Mar 12, 2023

Copy link
Copy Markdown
Contributor Author

Please see PR python/docsbuild-scripts#150.

m-aciek commented Mar 15, 2023

Copy link
Copy Markdown
Contributor Author

I just wanted to share a thought that in case of a need of some changes that would break backwards compatibility we can always decide to pin the theme version in CPython branch and remove a version from matrix. But still it will be easier to spot the breakage and pin the version in advance of releasing such changes having those tests in CI.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL