Override font for .sig for consistency with other code blocks - #121
Merged
JulienPalard merged 1 commit intoApr 18, 2023
Merged
JulienPalard merged 1 commit into
JulienPalard merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Would you mind showing the "before" and "after" screenshots of how it looks like with/without this change? Thank you. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
hugovk
approved these changes
Apr 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic.css Sphinx stylesheet introduces a .sig rule, which sets some monospace fonts for the signature. The pydoctheme.css stylesheet has its own list of fonts, applied to some other elements, but not .sig. The result is an inconsistency on Windows systems with both Cascadia Mono and Consolas installed (I believe that happens in a default Windows 11 install). Compare the glyphs for 64 in the function signature and in the code block below it: