Focus search box when pressing slash - #131
Closed
hugovk wants to merge 2 commits into
Closed
hugovk wants to merge 2 commits into
hugovk wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
python_docs_theme/static/search-focus.js
Closed
miketheman
added a commit
to miketheman/python-docs-theme
that referenced
this pull request
Jul 27, 2023
When the template was made responsive, the choice was made to override the `body_tag` fragment. The `body_tag` block is a literal `<body>` which allows the theme developer to set properties on the `body` tag. See: sphinx-doc/sphinx#4140 Instead, use the `document` block as documented. https://www.sphinx-doc.org/en/master/development/templating.html#blocks Overriding the correct block places the `mobile-nav` section _after_ the majority of the other HTML parts, which enables the correct function of the `/` keyboard shortcut. Resolves python#130 Closes python#131 Closes python#135 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Re-opening as #135 didn't work out. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Or the re-open button doesn't work after rebasing/force pushing, so here's a new PR: #153. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130.
Many websites focus the search box when the forward slash / key is pressed.
For example:
Let's do the same.
Demo
https://python-docs-theme-previews--131.org.readthedocs.build/en/131/