Do not append asset hashes on Sphinx 7.1+ - #137
Merged
hugovk merged 2 commits intoJul 29, 2023
Merged
hugovk merged 2 commits into
hugovk merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The relevant functionality has been added to Sphinx natively.
Copy link
Copy Markdown
Member
Author
|
Whoops, I accidentally used the wrong repo to send the branch to! Sorry about that! |
Sorry, something went wrong.
hugovk
approved these changes
Jul 26, 2023
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Like pradyunsg/furo@a92dd0c, thank you!
Great that Sphinx has included this!
Sorry, something went wrong.
AA-Turner
reviewed
Jul 26, 2023
Comment thread
python_docs_theme/__init__.py
Outdated
Sphinx 7.1 added the relevant functionality natively.
Copy link
Copy Markdown
Member
Author
|
(requesting a new review, since the implementation changed) |
Sorry, something went wrong.
hugovk
approved these changes
Jul 27, 2023
AA-Turner
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136