Don't let long code literals extend beyond the right side of the screen - #139
Merged
hugovk merged 2 commits intoJul 30, 2023
Merged
hugovk merged 2 commits into
hugovk merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AA-Turner
approved these changes
Jul 27, 2023
Copy link
Copy Markdown
Member
|
In Furo, I went ahead and set break-word on the entire content container in pradyunsg/furo@c8b51d0 That makes it so that no regular text/markup, including really long one-word titles don't trigger a rewrap by default, would have an overflow beyond that element. Do you think it's worth adopting a similar model here? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yes, that sounds better, would you like to update this PR or create a new one? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Updated, how does this look? |
Sorry, something went wrong.
pradyunsg
approved these changes
Jul 30, 2023
pradyunsg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129.
With mobile, compare: