Lint on GitHub Actions via pre-commit - #159
hugovk merged 1 commit into
Conversation
Sorry, something went wrong.
|
I triggered a test run on main and it also failed with only the exit code: python ./docsbuild-scripts/build_docs.py --quick --build-root ./build_root --www-root ./www --log-directory ./logs --group $(id -g) --skip-cache-invalidation --theme $(pwd) --language en --branch 3.12
shell: /usr/bin/bash -e {0}
env:
FORCE_COLOR: 1
pythonLocation: /opt/hostedtoolcache/Python/3.11.5/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.5/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.5/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.5/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.5/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.5/x64/lib
Error: Process completed with exit code 70.
https://github.com/python/python-docs-theme/actions/runs/6482294214/job/17601524907 Running the same command passes for me locally. |
Sorry, something went wrong.
| @@ -0,0 +1,2 @@ | |||
| [flake8] | |||
| max-line-length = 88 | |||
There was a problem hiding this comment.
Can/should this specified with a --flag (or disabled if black already checks this)?
If we do we can get rid of this file.
Sorry, something went wrong.
There was a problem hiding this comment.
It could be done with a flag, but then it would only apply to that invocation with the flag, and not if we run Flake8 myself from the command line. This file means it is read by both.
We can't remove it either. Black will set some files to 88 chars wide, and then Flake8 would complain because it's over 80.
Sorry, something went wrong.
There was a problem hiding this comment.
Fair enough.
Sorry, something went wrong.
| @@ -0,0 +1,2 @@ | |||
| [flake8] | |||
| max-line-length = 88 | |||
There was a problem hiding this comment.
Fair enough.
Sorry, something went wrong.
Add some pre-commit checks and apply autofixes. Also some minor config updates.
I also ran https://github.com/tox-dev/pyproject-fmt/ to reformat pyproject.toml to standardise it and make it much easier to compare with other repos. However, I didn't add it to pre-commit because it strips out the 3.13 classifier.