FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Dark mode: fix contrast of footer highlight by hugovk · Pull Request #162 · python/python-docs-theme · GitHub

Repository navigation

Dark mode: fix contrast of footer highlight - #162

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:fix-dark-mode-footer-highlight-contrast
Dec 4, 2023
Merged

hugovk merged 1 commit into
python:mainfrom
hugovk:fix-dark-mode-footer-highlight-contrast

Conversation

hugovk commented Dec 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

hugovk added the bug label Dec 3, 2023
hugovk merged commit 2c4de5a into python:main Dec 4, 2023
hugovk deleted the fix-dark-mode-footer-highlight-contrast branch December 4, 2023 18:11

ferdnyc commented Jan 26, 2024

Copy link
Copy Markdown

Hah! I was just coming here to get started on a similar pull request.

Unfortunately, while this is merged, it still isn't deployed on docs.python.org. Those docs still show the unreadable yellow background, in the dark theme.

Is there a procedure for getting the live docs to pull in theme updates?

hugovk commented Jan 26, 2024

Copy link
Copy Markdown
Member Author

Hah! I was just coming here to get started on a similar pull request.

Thank you!

Is there a procedure for getting the live docs to pull in theme updates?

Yes, the procedure is:

We have a few thing pending release, I'll make one later today or this weekend.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode: highlighted footnote unreadable

3 participants


Back | FazBrowse Home | New Git URL