FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Consistently reference `theme_root_icon` by mbudisic · Pull Request #163 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Consistently reference theme_root_icon - #163

Merged
AA-Turner merged 6 commits into
python:mainfrom
mbudisic:layout_reads_root_icon
Jan 12, 2024
ConversationCommits (6)ChecksFiles changed
Merged

Consistently reference theme_root_icon#163
AA-Turner merged 6 commits into
python:mainfrom
mbudisic:layout_reads_root_icon

Conversation

mbudisic commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

Removed explicit py.svg references in layout.html with theme_root_icon paths.

This pull request changes paths lines 17 and 103 to match line 74 in the base branch.

Update layout.html
137681f 
Removed explicit py.svg references with theme_root_icon paths

ghost commented Jan 9, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

hugovk commented Jan 10, 2024

Copy link
Copy Markdown
Member

Good idea.

Although "Logo" isn't a great alt text, can we also add something like root_icon_alt_text to the config?

mbudisic force-pushed the layout_reads_root_icon branch from 310da0a to 7c36c8e Compare January 10, 2024 20:40
theme.conf root_icon and root_icon_alt_text variables interpolated in…
099019d 
… layout.html

This fixes a partial integration of root_icon and adds the new variable root_icon_alt_text
mbudisic force-pushed the layout_reads_root_icon branch from 7c36c8e to 099019d Compare January 10, 2024 20:47
hugovk reviewed Jan 10, 2024
View reviewed changes
Comment thread python_docs_theme/theme.conf Outdated
Apply suggestions from code review
47684e2 
Capitalization fix

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk approved these changes Jan 11, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

mbudisic commented Jan 11, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for suggestions!

ezio-melotti reviewed Jan 11, 2024
View reviewed changes
Comment thread python_docs_theme/theme.conf
Options made adjacent in theme.conf for readability
0667e59 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
AA-Turner requested changes Jan 12, 2024
View reviewed changes

AA-Turner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Per the documentation:

This, however, is not the preferred way to concatenate strings! For string concatenation, have a look-see at the ~ operator.

https://jinja.palletsprojects.com/en/3.1.x/templates/#other-operators

~ (tilde)

Converts all operands into strings and concatenates them.

As

Comment thread python_docs_theme/layout.html Outdated
Comment thread python_docs_theme/layout.html Outdated
AA-Turner changed the title layout.html references theme_root_icon consistently Consistently reference theme_root_icon Jan 12, 2024
mbudisic requested a review from AA-Turner January 12, 2024 17:36
AA-Turner merged commit beb868f into python:main Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ezio-melotti ezio-melotti approved these changes
hugovk hugovk approved these changes
AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL