Show logs on error - #164
Merged
AA-Turner merged 1 commit intoJan 10, 2024
Merged
AA-Turner merged 1 commit into
AA-Turner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
m-aciek
approved these changes
Jan 10, 2024
Copy link
Copy Markdown
Contributor
|
By the way, the PR to fix the upstream: python/cpython#113815. |
Sorry, something went wrong.
AA-Turner
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the 3.8 and 3.9 branches are failing to build, but no error logs are printed on the CI due to sys.stderr.isatty() being false:
https://github.com/python/docsbuild-scripts/blob/f0a570aec824c7d775ea9d345a89d1b10d0f11b2/build_docs.py#L604-L617
This will show the logs if there's a failure.