| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
I left a few nitpicky comments, and I also have some additional bikeshedding, since the color choice of some admonition seems somewhat arbitrary to me:
We should also check how they look on some real-world example, and see if the colors (and maybe the boxes too) are too distracting. This might actually be the reason why they weren't added in the first place (maybe we should check with the original author too and ask them why they made that choice).
We might also want to leave the bikeshedding for a separate PR (especially if you just copied the colors from another theme) as not to stall this PR.
Sorry, something went wrong.
…ges and conflicts with background-color
|
Thanks all for the reviews, let's merge and release. We can adjust and iterate the others in the future. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Only some of the "admonitions" have backgrounds and borders, giving them slightly different indentations:
We're missing backgrounds and borders for most of them:
Other themes have them for all:
Let's also fill in the gaps.
Before
After
Screenshots using this from the Kitchen Sink:
Details