FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add script for handling translations by rffontenelle · Pull Request #195 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Add script for handling translations - #195

Merged
hugovk merged 15 commits into
python:mainfrom
rffontenelle:add-localization
Oct 28, 2024
ConversationCommits (15)ChecksFiles changed
Merged

Add script for handling translations#195
hugovk merged 15 commits into
python:mainfrom
rffontenelle:add-localization

Conversation

rffontenelle commented Aug 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is an initial take on the enable localization initiative adding a script to ease the babel call.

Usage:

python babel_runner.py extract           # generate translations template file (.pot)
python babel_runner.py init -l pt_BR     # generate a translation file (.po) for Brazilian Portuguese
python babel_runner.py update            # update all .po files using the existing .pot; or
python babel_runner.py update -l pt_BR   # update only the pt_BR.po
python babel_runner.py compile           # compile all .po files using the existing .pot; or
python babel_runner.py compile -l pt_BR  # compile only the pt_BR.po

See #194

hugovk reviewed Aug 2, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for this! Please could you add it somehow to the CI, so we know it at least runs without errors?

I was thinking if this script could be converted into Makefile commands, but then we won't have Windows support, so that's no good. But we could add Makefile commands to call this script. This can be left for later though.

Comment thread babel_runner.py Outdated

rffontenelle commented Aug 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@hugovk workflow job added to tests.yml. My intention is to show the script works, but we can shape it better.

Wulian233 reviewed Aug 3, 2024
View reviewed changes
Comment thread .github/workflows/tests.yml Outdated
AA-Turner reviewed Aug 3, 2024
View reviewed changes
Comment thread .github/workflows/tests.yml Outdated
AA-Turner reviewed Aug 3, 2024
View reviewed changes
Comment thread babel_runner.py Outdated
AA-Turner reviewed Aug 3, 2024
View reviewed changes
Comment thread babel_runner.py Outdated
AA-Turner mentioned this pull request Aug 3, 2024
Merged

Wulian233 commented Sep 17, 2024

Copy link
Copy Markdown

It looks like this PR hasn't had a new activity in a while, is it finished now?

hugovk reviewed Oct 26, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few nits, then I think we can merge this and iterate if needed, unless anyone else has any last comments?

Comment thread .github/workflows/tests.yml Outdated
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated

Wulian233 commented Oct 27, 2024 •
edited
Loading

Copy link
Copy Markdown

In the Simplified Chinese documentation, there is an issue regarding hard-coded (edit: not hard-coded) strings such as "added in version". that cannot be translated. Can this PR solve this problem?

python/python-docs-zh-cn#364

rffontenelle commented Oct 27, 2024

Copy link
Copy Markdown
Contributor Author

In the Simplified Chinese documentation, there is an issue regarding hard-coded strings such as "added in version" and "deprecated in version" etc. that cannot be translated. Can this PR solve this problem?

python/python-docs-zh-cn#364

No, that's a Sphinx string and it is not translated to zh_CN: https://github.com/sphinx-doc/sphinx/blob/116a430caca98580c8877cf7b0ba270eae9604bf/sphinx/locale/zh_CN/LC_MESSAGES/sphinx.po#L1951

Consider contributing in https://explore.transifex.com/sphinx-doc/sphinx-1/

Wulian233 mentioned this pull request Oct 27, 2024
Open
ezio-melotti reviewed Oct 28, 2024
View reviewed changes
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated
Comment thread babel_runner.py Outdated
rffontenelle and others added 4 commits October 28, 2024 08:23
Apply suggestions from code review
bd7c059 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Remove possibly existing translation file
65a0360 
Otherwise init command will be skipped
Add shell bash to success in Windows
69ab917
Swap init and extract to be didactic
2aa3a04 
As one need to have POT before initializing PO

rffontenelle commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

A few nits, then I think we can merge this and iterate if needed, unless anyone else has any last comments?

That's all from my side. Just a few minor changes.

rffontenelle mentioned this pull request Oct 28, 2024
Open
hugovk approved these changes Oct 28, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

Wulian233 commented Oct 28, 2024

Copy link
Copy Markdown

It looks great! I have a question: where should we translate this theme, and how will the translation automatically sync to this repository?

rffontenelle commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

@Wulian233 I mentioned that in the issue and it is yet to be defined.

Some projects coordinate translation efforts in the own forge via pull/merge requests — not optimal for the translators. There is also translation platforms like Weblate, Transifex and others.

My vote would be to use Weblate, which provides "libre hosting" for free software and features automatic opening and updating pull request for contributed translations. Tasks involve: setting up Weblate project (I can help with/do it), maintainers here update POT and give time before releasing to receive translations; and merging translation pull requests from Weblate.

hugovk merged commit 3c53d33 into python:main Oct 28, 2024
rffontenelle deleted the add-localization branch October 28, 2024 14:24
rffontenelle mentioned this pull request Aug 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
ezio-melotti ezio-melotti left review comments
hugovk hugovk approved these changes
+1 more reviewer
Wulian233 Wulian233 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL