FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Note minimum requirements for Sphinx by AA-Turner · Pull Request #216 · python/python-docs-theme · GitHub

Repository navigation

Note minimum requirements for Sphinx - #216

Merged
AA-Turner merged 3 commits into
python:mainfrom
AA-Turner:sphinx-reqs
Jan 28, 2025
Merged

AA-Turner merged 3 commits into
python:mainfrom
AA-Turner:sphinx-reqs

Conversation

AA-Turner commented Jan 27, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

We implicitly support the versions used in CPython. However, Python 3.9 uses a pinned version of this theme (python/cpython#115351), so we can explicitly document our minimum supported versions as those used in the Python 3.10 branch.

A


📚 Documentation preview 📚: https://python-docs-theme-previews--216.org.readthedocs.build/

Comment thread README.md
# Python Docs Sphinx Theme

This is the theme for the Python documentation.
It requires Python 3.9 or newer and Sphinx 3.4 or newer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In another project we noticed the Python version mentioned in docs said 3.6+, but in reality it's 3.9+ and we'd forgotten to update that three times!

To DRY, perhaps we don't need to document this in words, seeing as we have definitive metadata in pyproject.toml?

That is:

requires-python = ">=3.9"
...
dependencies = [
  "sphinx>=3.4",
]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suppose I put it in the README to make it very clear -- perhaps we could replace it with a policy statement instead? I.e.:

"It supports all Sphinx versions required by the stable Python branches."

I'm not a huge fan of this wording, though -- it feels clunky.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well, it's okay to leave this in the README if you like, at least it's the repo's first page and not some other "hidden"/forgotten docs page.

AA-Turner merged commit 01d5bcf into python:main Jan 28, 2025
AA-Turner deleted the sphinx-reqs branch January 28, 2025 01:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL