| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Could we do a percentage width of say 25% (so 256px at the lower bound before the sidebar disappears)? |
Sorry, something went wrong.
|
Just to clarify, you mean to have a fixed sidebar width of 256px or some kind of dynamic sizing? The latter would require additional style changes |
Sorry, something went wrong.
|
A width defined in % or vw units, yes. |
Sorry, something went wrong.
|
We might need some more breakpoints for that - 25vw might be too much on very wide screens |
Sorry, something went wrong.
|
And maybe an upper bound where it's a fixed width, compare: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/index.html As it stands, this is PR good for mobile, the sidebar is always shown: Screenshot |
Sorry, something went wrong.
|
I made the sidebar more like the pydata theme Hugo shared. The width is now calculated as min(25vw, 350px) so it is at maximum 350px and at minimum 256px (just before it gets hidden).
Fixed, some of the selectors I was using were too specific. |
Sorry, something went wrong.
| } | ||
|
|
||
| div.sphinxsidebar { | ||
| display: flex; |
There was a problem hiding this comment.
Is flexbox required here?
Sorry, something went wrong.
There was a problem hiding this comment.
This allows me to remove the hardcoded width: 217px; from div.sphinxsidebarwrapper
Sorry, something went wrong.
|
(There's a conflict after merging #219.) |
Sorry, something went wrong.
Will fix it in a bit |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
|
Thanks for the reviews/comments! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Related issue: #209
This is a less disruptive version of #214
This simply increases the width of the sidebar to 260px (not set in stone, happy to discuss the appropriate value)
Two more things I considered that we could discuss but didn't include in the PR
Feedback welcome!
📚 Documentation preview 📚: https://python-docs-theme-previews--218.org.readthedocs.build/