FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable theme translation by StanFromIreland · Pull Request #246 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Enable theme translation - #246

Merged
hugovk merged 10 commits into
python:mainfrom
StanFromIreland:localize-theme
Sep 7, 2025
ConversationCommits (10)ChecksFiles changed
Merged

Enable theme translation#246
hugovk merged 10 commits into
python:mainfrom
StanFromIreland:localize-theme

Conversation

StanFromIreland commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Adds Polish to start. Based on @rffontenelle 's pr. This does not allow for translation of the Copy button for some reason, but I think that can be left for another time.

Result:

📚 Documentation preview 📚: https://python-docs-theme-previews--246.org.readthedocs.build/

🇵🇱 Polish preview 🇵🇱

StanFromIreland marked this pull request as ready for review August 7, 2025 15:12
StanFromIreland marked this pull request as draft August 7, 2025 15:13
StanFromIreland marked this pull request as ready for review August 7, 2025 17:19
StanFromIreland changed the title Localize theme Enable theme translation Aug 7, 2025
rffontenelle mentioned this pull request Aug 7, 2025
Closed

rffontenelle commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Thanks for fixing what was missing with the solution!

rffontenelle mentioned this pull request Aug 8, 2025
Closed
m-aciek reviewed Aug 8, 2025
View reviewed changes

m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Translation improvement suggestions, otherwise looks good to me 👍

Comment thread python_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment thread python_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment thread python_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment thread python_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment thread python_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
m-aciek reviewed Aug 9, 2025
View reviewed changes

m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Suggestion for better portability

Comment thread python_docs_theme/__init__.py Outdated
Apply suggestions from Maciek
49f99d8 
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
yeager added a commit to yeager/python-docs-theme that referenced this pull request Aug 29, 2025
Adding Swedish translation
6ba31eb 
Pre-req python#246
yeager mentioned this pull request Aug 29, 2025
Merged
StanFromIreland requested a review from hugovk August 29, 2025 15:06
hugovk reviewed Sep 2, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks about right, but I'd appreciate a PR approval from a translator as well.

And we can always iterate and fix as needed after an initial release.

Comment thread babel_runner.py Outdated
Comment thread babel_runner.py
AA-Turner reviewed Sep 2, 2025
View reviewed changes
Comment thread python_docs_theme/__init__.py Outdated

StanFromIreland commented Sep 2, 2025

Copy link
Copy Markdown
Member Author

Looks about right, but I'd appreciate a PR approval from a translator as well.

Maciek has already reviewed translation, see above.

hugovk commented Sep 2, 2025

Copy link
Copy Markdown
Member

Looks about right, but I'd appreciate a PR approval from a translator as well.

Maciek has already reviewed translation, see above.

Yes, but not approved.

StanFromIreland commented Sep 2, 2025

Copy link
Copy Markdown
Member Author

In hopes of getting this in faster, I can just delete it?

Fun fact, translations of the Python docs are actually not reviewed for most languages.

StanFromIreland commented Sep 2, 2025

Copy link
Copy Markdown
Member Author

Preview! (built with -D language='pl')

m-aciek approved these changes Sep 2, 2025
View reviewed changes

m-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Thanks

Comment thread .gitignore
Comment thread babel_runner.py
hugovk reviewed Sep 3, 2025
View reviewed changes
Comment thread .gitignore
Comment thread python_docs_theme/locales/pl_PL/LC_MESSAGES/messages.mo Outdated

StanFromIreland commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

It is no longer a follow up, it is now included in this PR!

Verified manually that the artefact has the compiled files.

StanFromIreland mentioned this pull request Sep 3, 2025
Closed

rffontenelle commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Sweet! Was setup-python really necessary, considering that python is already included in the GH runner image?

StanFromIreland commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

It is used in all other workflows in this repository when Python is needed.

hugovk approved these changes Sep 5, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

hugovk merged commit 4f43ade into python:main Sep 7, 2025
10 checks passed
StanFromIreland deleted the localize-theme branch September 7, 2025 17:26
StanFromIreland mentioned this pull request Apr 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
AA-Turner Awaiting requested review from AA-Turner
+2 more reviewers
rffontenelle rffontenelle left review comments
m-aciek m-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL