Make copybutton messages translatable - #27
ccwang002 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
There's a little issue, the command gathering translations strings: sphinx-build -Q -b gettext -D gettext_compact=0 Doc pot/ won't pick it up, so translation teams won't see it as a sentence to translate. I don't have the time right now to check if there's a simple way to solve this, maybe Sphinx has a way to look for translations strings in configured theme? |
Sorry, something went wrong.
|
These resources might be helpful: |
Sorry, something went wrong.
|
I think I looked into this in the past and it was possible to directly translate the strings in the javascript file |
Sorry, something went wrong.
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
Sorry, something went wrong.
|
I believe so, the button title is now properly i18n'd. |
Sorry, something went wrong.
This PR implements #23 which make the messages of copybutton (>>>) translatable.
When I tested my change using the master branch of Python (branch 3.7 doesn't seem to use python-docs-theme), I couldn't get it read my modified layout.html. However, if I manually introduced the change, the pot files would include the new strings and the translation worked.
I think it is better to have someone more familiar with the project structure of PEP 545 to test my implementation before it is merged.