FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for Python 3.15 by hugovk · Pull Request #282 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Add support for Python 3.15 - #282

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:add-3.15
Nov 28, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Add support for Python 3.15#282
hugovk merged 1 commit into
python:mainfrom
hugovk:add-3.15

Conversation

hugovk commented Nov 26, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

The earlier approach was something like:

      matrix:
        branch: ["main", "3.14", "3.13", "3.12"]
...
          python-version: ${{ matrix.branch == 'main' && '3.15' || matrix.branch }}
...
          --branches ${{ matrix.branch }}

Which do you prefer?

📚 Documentation preview 📚: https://python-docs-theme-previews--282.org.readthedocs.build/

hugovk added enhancement github_actions Pull requests that update GitHub Actions code labels Nov 26, 2025
AA-Turner reviewed Nov 26, 2025
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If it were me, I'd probably duplicate the jobs -- one for released & one for in-development.

ezio-melotti approved these changes Nov 28, 2025
View reviewed changes
Comment thread .github/workflows/tests.yml
Comment on lines +16 to +18
include:
- python-version: "3.15"
branch: "main"

ezio-melotti Nov 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A possible improvement is to compute the branch and extra opts once and assign them to env vars:

Suggested change
include:
- python-version: "3.15"
branch: "main"
include:
- python-version: "3.15"
branch: "main"
extra_opts: '--select-output no-html'
env:
# set the branch name to either 'main' or the version number
BRANCH: ${{ matrix.branch || matrix.version }}
# define optional extra options if specified
EXTRA_OPTS: ${{ matrix.extra_opts || '' }}

This keeps all the data and logic closer and avoids duplication. However we only need the branch and the extra opts once in the workflow, so your less-verbose solution is fine too.

hugovk Nov 28, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, that is quite a bit more verbose, let's stick with the current version. Thanks!

Comment thread .github/workflows/tests.yml
Comment on lines +44 to +45
--branches ${{ matrix.branch || matrix.python-version }}
${{ matrix.branch == 'main' && '--select-output no-html' || '' }}

ezio-melotti Nov 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
--branches ${{ matrix.branch || matrix.python-version }}
${{ matrix.branch == 'main' && '--select-output no-html' || '' }}
--branches env.BRANCH env.EXTRA_OPTS

hugovk merged commit 4e36f99 into python:main Nov 28, 2025
15 checks passed
hugovk deleted the add-3.15 branch November 28, 2025 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
ezio-melotti ezio-melotti approved these changes

Assignees

No one assigned

Labels

enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL