Fix install from sdist for RTD - #320
Merged
StanFromIreland merged 1 commit intoJul 27, 2026
Merged
StanFromIreland merged 1 commit into
StanFromIreland merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Documentation build overview11 files changed · ± 11 modified ± Modified |
Sorry, something went wrong.
StanFromIreland
approved these changes
Jul 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile wasn't quite working as intended. This is used for RTD builds.
Before
It intends to build an sdist and then install from that. But:
https://app.readthedocs.org/projects/python-docs-theme-previews/builds/33742569/
This is because the filenames are now normalised and look like python_docs_theme-2026.4.tar.gz
But anyway, it was evaluating this before even running $(PYTHON) -m build:
So even the correct name wouldn't find it.
But it was then installing from PyPI as part of the normal docs build:
And then ./venv/bin/pip install $(PACKAGE_ABS_PATH) was just doing an install from the current directory, so we ended up with the local dev version after all:
Building wheels for collected packages: python-docs-theme Building wheel for python-docs-theme (pyproject.toml): started Building wheel for python-docs-theme (pyproject.toml): finished with status 'done' Created wheel for python-docs-theme: filename=python_docs_theme-2026.4-py3-none-any.whl size=47033 sha256=2ef5cfd56d04c28218e833d12a81b068b485bef38818c88da1b99c670bcb2ce3 Stored in directory: /tmp/pip-ephem-wheel-cache-36pb2g5u/wheels/9c/8a/8b/1187bbb4cb469b4e87f8aee1562b67ba81301f0ababe695fea Successfully built python-docs-theme Installing collected packages: python-docs-theme Attempting uninstall: python-docs-theme Found existing installation: python-docs-theme 2026.4 Uninstalling python-docs-theme-2026.4: Successfully uninstalled python-docs-theme-2026.4 Successfully installed python-docs-theme-2026.4After
Fix installing from sdist.
Remove PACKAGE_ABS_PATH and let the shell expand the normalised glob when pip runs, after the sdist is built. Also clear dist/ before building, so a stale tarball from a previous build can't make the glob match two files.