FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix: searchbox is wrapping under the separation line for screen sizes by tapaswenipathak · Pull Request #33 · python/python-docs-theme · GitHub

Repository navigation

Fix: searchbox is wrapping under the separation line for screen sizes - #33

Closed
tapaswenipathak wants to merge 1 commit into
python:mainfrom
tapaswenipathak:issue-7
Closed

tapaswenipathak wants to merge 1 commit into
python:mainfrom
tapaswenipathak:issue-7

Conversation

Copy link
Copy Markdown
Contributor

Fixes #7.

Hello maintainers: folks who feel ok for reviewing the css changes?

cc @theacodes @ncoghlan @brettcannon @Mariatta (top contributors).

Copy link
Copy Markdown
Member

@tapaswenipathak please be careful about @ mentioning folks blindly to try and get a review. For instance, I have only contributed twice, so I'm not in a good position to review anything in this repo and I have 25 other notifications in GitHub right now and so this is unfortunately a distraction for me when I can't help.

But I will say thanks for trying and hopefully someone in a better position will be able to review your changes.

Copy link
Copy Markdown
Member

Thanks for trying to enhance the CSS, I appreciate it, while not being able to understand it. Hope someone can review this :)

Copy link
Copy Markdown
Contributor Author

@brettcannon: People tagged are the top contributors in the repository and maintainers in the org, I think, how else you can decide who can review the PR. No problem if you technically still don't understand the changes. Thanks for taking the time for writing what you think.

Copy link
Copy Markdown
Member

@tapaswenipathak I would say it's not your problem to have to know who should review the PR. It's up to the project to decide how they want to handle assigning PR reviews and make sure there is a process in place to handle that.

hugovk commented Jan 31, 2023

Copy link
Copy Markdown
Member

Thanks for the PR, this has since been fixed by the responsive theme (#46):

#7 (comment)

Let's close this.

hugovk closed this Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search box is wrapping when screen size is reduced

5 participants


Back | FazBrowse Home | New Git URL