Fix sidebarbutton CSS styling - #332
sepehr-rs wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Documentation build overview19 files changed · ± 19 modified ± Modified |
Sorry, something went wrong.
Co-authored-by: Stan Ulbrych <stan@python.org>
|
Building the documentation with this change, I'm not sure we need to change anything here? (I wanted to attach screenshots, but something seems to be wrong and GitHub isn't displaying them.) « and » are mirrored characters in Unicode so when the text runs right-to-left, the browser automatically switches « for ». Looking at the current documentation, this looks correct for both LTR and RTL. With this PR, it's flipped twice and is wrong. Maybe this is browser specific, however, in Firefox it is correct. |
Sorry, something went wrong.
|
Huh, weird. You're right. In Firefox the button doesn't render correctly, but I checked Chrome just to be sure, and it looks okay there: I'll close the PR then. Thanks for taking the time to look into it! |
Sorry, something went wrong.
This PR fixes the sidebar button being reversed, as mentioned in #331. We can remove this once RTL support is added to Sphinx, since the sidebar button is originally managed by Sphinx. Please let me know if any changes are needed!