FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ by zmwangx · Pull Request #57 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ - #57

Merged
pablogsal merged 1 commit into
python:masterfrom
zmwangx:codebgcolor-codetextcolor
Dec 19, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+#57
pablogsal merged 1 commit into
python:masterfrom
zmwangx:codebgcolor-codetextcolor

Conversation

zmwangx commented Oct 10, 2020

Copy link
Copy Markdown
Contributor

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme (see commit sphinx-doc/sphinx@b345acc), leaving pre elements uncolored.

Without the fix:

Should be:

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+
197546f 
Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic
theme[1], leaving pre elements uncolored.

[1] sphinx-doc/sphinx@b345acc
zmwangx added a commit to zmwangx/dim that referenced this pull request Oct 10, 2020
doc: fix codebgcolor and codetextcolor
464b774 
See python/python-docs-theme#57.

Also blacken.

zmwangx commented Oct 10, 2020

Copy link
Copy Markdown
Contributor Author

Wait, was this change intentional? Just noticed that Python 3.10 docs, rendered with Sphinx 3.2.1, features background color-less code blocks.

In any case I certainly prefer the old style.

JulienPalard commented Oct 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Looks related to sphinx-doc/sphinx#7720 / sphinx-doc/sphinx#7721

zmwangx commented Oct 10, 2020

Copy link
Copy Markdown
Contributor Author

Yeah, sphinx-doc/sphinx#7720 led to sphinx-doc/sphinx#7721 led to sphinx-doc/sphinx@b345acc.

corona10 commented Oct 17, 2020

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42042

pablogsal merged commit e77bd1a into python:master Dec 19, 2020

pablogsal commented Dec 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@Mariatta Do you happen to know who has privileges to publish a new version to pypi? We need a new version to restore the colourized backgrounds.

Mariatta commented Dec 19, 2020

Copy link
Copy Markdown
Member

I can publish this later this evening.

zmwangx deleted the codebgcolor-codetextcolor branch December 21, 2020 05:27

Mariatta commented Dec 22, 2020

Copy link
Copy Markdown
Member

We've released v 2020.12
On PyPI: https://pypi.org/project/python-docs-theme/2020.12/
Changelog https://github.com/python/python-docs-theme/releases/tag/v2020.12

pablogsal commented Dec 22, 2020

Copy link
Copy Markdown
Member

Thanks a lot @Mariatta!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL