FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use default pygments theme by Blendify · Pull Request #68 · python/python-docs-theme · GitHub

Repository navigation

Use default pygments theme - #68

Merged
JulienPalard merged 1 commit into
python:masterfrom
Blendify:patch-1
May 1, 2021
Merged

JulienPalard merged 1 commit into
python:masterfrom
Blendify:patch-1

Conversation

Copy link
Copy Markdown
Contributor

The default theme looks a lot better than the default theme with the green background.

The default theme looks a lot better than the default theme with the green background.

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Blendify

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Copy Markdown
Member

Before :

After :

Copy link
Copy Markdown
Member

Is anything blocking this merging?

Copy link
Copy Markdown
Member

I think it's subjective, I fear someone will open a PR to use Sphinx instead of defaut telling it looks better and we enter an infinite loop.

So what's blocking this PR is the lack of concensus. Maybe open an poll on discuss.python.org or twitter, and if the concensus is clear, we could merge this.

  • I see one good point: redish literals do pop out cleaner.
  • I see one bad point: light grey output is less readable.

Copy link
Copy Markdown
Member

I can apport a non-subjective point: I am very colorblind and I can read much better the second one

Copy link
Copy Markdown
Member

I can apport a non-subjective point: I am very colorblind and I can read much better the second one

Thanks for your feedback!

JulienPalard merged commit 5586486 into python:master May 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL