FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove id searchbox on mobile to fix a layout bug by obulat · Pull Request #76 · python/python-docs-theme · GitHub

Repository navigation

Remove id searchbox on mobile to fix a layout bug - #76

Merged
JulienPalard merged 1 commit into
python:masterfrom
obulat:patch-2
May 12, 2021
Merged

JulienPalard merged 1 commit into
python:masterfrom
obulat:patch-2

Conversation

obulat commented May 9, 2021

Copy link
Copy Markdown
Contributor

Sphinx in doctools.js uses an element with id searchbox to append a paragraph saying "Hide search matches". It is currently not used in the Python docs, but with the responsive theme, it breaks the layout. The search box at the top has a "Hide search matches" link to the right of it:

To reproduce:

  1. Go to the 3.11 version of the docs
  2. Narrow your screen to mobile width
  3. Search for something (eg. "xml rpc")
  4. Click on one of the search results (eg. "xmlrpc.client — XML-RPC client access")

I removed the id from the search form in the top menu bar so that this link is not added.

JulienPalard merged commit 4dcc3b4 into python:master May 12, 2021

Copy link
Copy Markdown
Member

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL