FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a configuration for license URL. by JulienPalard · Pull Request #90 · python/python-docs-theme · GitHub

Repository navigation

Add a configuration for license URL. - #90

Merged
JulienPalard merged 1 commit into
python:masterfrom
JulienPalard:mdk-license-url
Jan 11, 2022
Merged

JulienPalard merged 1 commit into
python:masterfrom
JulienPalard:mdk-license-url

Conversation

Copy link
Copy Markdown
Member

closes #89

You're right @merwok, the assignment were reversed (and useless so they were not introducing a bug).

I made the link to the license configurable, so we could add license_url cpython side to point to it (near it's issues_url in Doc/config.py)

Copy link
Copy Markdown
Member

Would make sense to have at least have a fallback to the previous behavior if the theme variables are undefined, as was implemented on #67 per my suggestion there, for backward compatibility and to follow the approach there for the copyright link? Other than that, this is a pretty important change, since the link is broken at present.

Copy link
Copy Markdown
Member Author

The current "fallback" is just not to display the link, I'm not sure we can do better here. Do you have something better in mind?

CAM-Gerlach commented Dec 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Yeah, sorry for the delay—what I was suggesting you could do something like was done for the copyright URL right above it, fall back to a corrected version of the previous behavior, i.e. the hardcoded path, unless the existing behavior was always broken and never actually functioned as intended (which may be the case, I didn't trawl through the full commit history to check).

Copy link
Copy Markdown
Member Author

I'm puzzeled: the current implementation works on some pages but not all. It works at least on:

Copy link
Copy Markdown
Member Author

Hum, no, I'm just not awaken yet, on those page, it work like on many other pages: it redirects on the "Current page". In all cases it's a <a href="".

Copy link
Copy Markdown
Member Author

I modified my PR a bit to avoid changing the msgid for translators.

JulienPalard merged commit 6c2b38f into python:master Jan 11, 2022
JulienPalard deleted the mdk-license-url branch January 11, 2022 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty history & license link in Python docs footer

3 participants


Back | FazBrowse Home | New Git URL