Fix mobile nav obstructing content - #96
Merged
pradyunsg merged 1 commit intoFeb 13, 2023
Merged
pradyunsg merged 1 commit into
pradyunsg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
(Rebased on main to retrigger the CI and create an RTD build preview: https://python-docs-theme-previews--96.org.readthedocs.build/en/96/) |
Sorry, something went wrong.
hugovk
approved these changes
Feb 13, 2023
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Testing locally with the banner enabled on the 3.8 branch:
diff --git a/Doc/tools/templates/layout.html b/Doc/tools/templates/layout.html
index 98ccf42248..0151a00593 100644
--- a/Doc/tools/templates/layout.html
+++ b/Doc/tools/templates/layout.html
@@ -1,13 +1,11 @@
{% extends "!layout.html" %}
{% block header %}
-{%- if outdated %}
<div id="outdated-warning" style="padding: .5em; text-align: center; background-color: #FFBABA; color: #6A0E0E;">
{% trans %}This document is for an old version of Python that is no longer supported.
You should upgrade, and read the {% endtrans %}
<a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the current stable release{% endtrans %}</a>.
</div>
-{%- endif %}
{% endblock %}
{% block rootrellink %}Before
| 
|
After
| 
|
Sorry, something went wrong.
pradyunsg
approved these changes
Feb 13, 2023
Copy link
Copy Markdown
Member
|
Thanks for the screenshots on this @hugovk! ^.^ |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of adding the height of .mobile-nav at the top of .document it is now added at the top of body.
Closes #95